Skip to content

Updated to latest Github Actions Version#297

Merged
AlvaroRausell merged 13 commits intodevcontainers:mainfrom
gvatsal60:update_action_#296_VG
Oct 28, 2025
Merged

Updated to latest Github Actions Version#297
AlvaroRausell merged 13 commits intodevcontainers:mainfrom
gvatsal60:update_action_#296_VG

Conversation

@gvatsal60
Copy link
Copy Markdown
Contributor

@gvatsal60 gvatsal60 commented Nov 3, 2024 •
edited
Loading

  • Updated the action to the latest version.
  • Added a customization in devcontainer.json to handle trailing whitespace.
  • Automated Updates: Dependabot will automatically submit pull requests whenever an update is available for any GitHub Actions, reducing manual maintenance work.

@gvatsal60 gvatsal60 requested a review from a team as a code owner November 3, 2024 12:54
gvatsal60
gvatsal60 commented Nov 3, 2024
View reviewed changes
Comment thread .devcontainer/devcontainer.json Outdated
@gvatsal60
Copy link
Copy Markdown
Contributor Author

gvatsal60 commented Dec 18, 2024

Hi @bamurtaugh,

I’ve already submitted the PR for #296, but it seems I forgot to link it to the issue. My apologies for the oversight.

@gvatsal60 gvatsal60 mentioned this pull request Dec 18, 2024
Closed
@bamurtaugh bamurtaugh requested a review from chrmarti January 6, 2025 17:24
chrmarti
chrmarti previously requested changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I don't see us set "editor.trimAutoWhitespace": true in other repositories and I'm not sure how much noise this will generate. Could you omit that?

@gvatsal60
Omitted editor.trimAutoWhitespace": true
5f84baf 
Omitted `"editor.trimAutoWhitespace": true`
@gvatsal60 gvatsal60 requested a review from chrmarti April 12, 2025 05:27
@gvatsal60
Copy link
Copy Markdown
Contributor Author

gvatsal60 commented Jun 10, 2025

Hey @chrmarti ,

Would you mind reviewing this PR when you get a chance? Your feedback would be really helpful! Let me know if you need any additional context.

Thanks!

@chrmarti
Copy link
Copy Markdown
Contributor

chrmarti commented Jun 18, 2025

Thanks for the PR and sorry for the delay! Files Changed on this PR no longer show any changes. Maybe the dependabot updates took care of it?

gvatsal60
gvatsal60 commented Jun 18, 2025
View reviewed changes
Comment thread .github/dependabot.yml
@gvatsal60
Copy link
Copy Markdown
Contributor Author

gvatsal60 commented Jun 18, 2025 •
edited
Loading

Thanks for the PR and sorry for the delay! Files Changed on this PR no longer show any changes. Maybe the dependabot updates took care of it?

Thanks for checking! There are still some changes showing in the PR.

AlvaroRausell
AlvaroRausell approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! (and apologies for the delay)

@AlvaroRausell AlvaroRausell removed the request for review from chrmarti October 28, 2025 11:13
@AlvaroRausell AlvaroRausell dismissed chrmarti’s stale review October 28, 2025 11:13

Dismissing as user made the right changes

@AlvaroRausell AlvaroRausell merged commit 30269da into devcontainers:main Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrmarti chrmarti chrmarti left review comments

+2 more reviewers

@AlvaroRausell AlvaroRausell AlvaroRausell approved these changes

@Thewizard7071 Thewizard7071 Thewizard7071 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gvatsal60 @chrmarti @AlvaroRausell @Thewizard7071